Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Bump web to v5.3.0-rc.1 #3291

Merged
merged 1 commit into from
Mar 10, 2022
Merged

[full-ci] Bump web to v5.3.0-rc.1 #3291

merged 1 commit into from
Mar 10, 2022
+23 −22

Conversation

pascalwengerter
Copy link
Contributor

Description

Pre-release to introduce a bunch of spaces UI improvements (huge kudos to @janackermann and @JammingBen ), alongside other fixes & stuff.

@pascalwengerter
Copy link
Contributor Author

Damn, forgot to update the settings tests 🤦‍♂️ will do so tomorrow morning

@kulmann
Copy link
Member

kulmann commented Mar 10, 2022

There's a typo in the german translations. Let's make an rc2 and wait with this PR for that. Objections?

@pascalwengerter pascalwengerter force-pushed the update-web-5-3-0-rc1 branch 2 times, most recently from c9a352a to 3a854d8 Compare March 10, 2022 09:20
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pascalwengerter
Copy link
Contributor Author

There's a typo in the german translations. Let's make an rc2 and wait with this PR for that. Objections?

Nope, sounds good to me. CI is green but the typo would need to be fixed in settings/ui/tests/acceptance/helpers/language.js 🦖

@pascalwengerter pascalwengerter merged commit 002b770 into master Mar 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-web-5-3-0-rc1 branch March 10, 2022 11:50
@pascalwengerter
Copy link
Contributor Author

There's a typo in the german translations. Let's make an rc2 and wait with this PR for that. Objections?

Nope, sounds good to me. CI is green but the typo would need to be fixed in settings/ui/tests/acceptance/helpers/language.js 🦖

Will follow up with an RC.2 (typo fixes and new features) soon

@kulmann
Copy link
Member

kulmann commented Mar 10, 2022

Let's merge. The next rc is just around the corner, but this already unblocks other stuff.

ownclouders pushed a commit that referenced this pull request Mar 10, 2022
commit 002b770
3cbd260 
Merge: a01dbd7 3a854d8
Author: Pascal Wengerter <pwengerter@owncloud.com>
Date:   Thu Mar 10 12:50:22 2022 +0100

    Merge pull request #3291 from owncloud/update-web-5-3-0-rc1

    [full-ci] Bump web to v5.3.0-rc.1
@micbar micbar mentioned this pull request Mar 29, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pascalwengerter @kulmann @AlexAndBear